test(netutil): add tests for StoppableListener #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## test_proto_add_storage_node_descriptor_validation_tests #936 +/- ##
===========================================================================================
- Coverage 80.02% 79.90% -0.12%
===========================================================================================
Files 179 179
Lines 21587 21587
===========================================================================================
- Hits 17275 17250 -25
- Misses 3529 3550 +21
- Partials 783 787 +4 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
acf7b7c to
70db730
Compare
ijsong
force-pushed
the
test_netutil_add_tests_for_stoppablelistener
branch
from
44c7bb6 to
eeb910a
Compare
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
70db730 to
5d84f35
Compare
ijsong
force-pushed
the
test_netutil_add_tests_for_stoppablelistener
branch
from
eeb910a to
e097a93
Compare
- Added unit tests for StoppableListener to cover various scenarios: - Valid and invalid addresses - Accepting connections after stopping - Successful connection acceptance - Improved test coverage and ensured reliability of the StoppableListener implementation.
ijsong
force-pushed
the
test_proto_add_storage_node_descriptor_validation_tests
branch
from
5d84f35 to
4e83134
Compare
ijsong
force-pushed
the
test_netutil_add_tests_for_stoppablelistener
branch
from
e097a93 to
e5da418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
implementation.