feat(storagenode): remove package internal/batchlet #967
+52
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
- Coverage 80.21% 80.04% -0.18%
==========================================
Files 179 178 -1
Lines 21583 21505 -78
==========================================
- Hits 17313 17213 -100
- Misses 3489 3505 +16
- Partials 781 787 +6 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
485f6c6 to
fc7d431
Compare
hungryjang
approved these changes
Feb 1, 2025
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
daf76e3 to
b43dd94
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
fc7d431 to
2e40f11
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
b43dd94 to
7f3f55b
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
2e40f11 to
647cba4
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
7f3f55b to
af1d282
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
647cba4 to
07bb027
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
af1d282 to
2f2da48
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
07bb027 to
ddda877
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
2f2da48 to
e45594e
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
ddda877 to
c805615
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
e45594e to
6ab1224
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
c805615 to
d694a78
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
6ab1224 to
e3a2b84
Compare
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
d694a78 to
c70817c
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
e3a2b84 to
07f5bec
Compare
Base automatically changed from
refactor_logstream_deprecate_old_replicatetask_pool_management
to
main
February 21, 2025 12:56
This PR removes the package internal/batchlet that is kind of small batch. Thus batch in Append RPC message is not splitted any more.
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
c70817c to
d309674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the package internal/batchlet that is kind of small batch. Thus
batch in Append RPC message is not splitted any more.