fix: prevent panic on partial append failures #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During partial append failures, the error field was incorrectly accessed from a nil err variable instead of the result struct, causing a nil pointer dereference panic. Change err.Error() to res[idx].Error to properly handle error messages in partial failure cases.
|
|
ijsong
approved these changes
Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 78.86% 78.93% +0.07%
==========================================
Files 180 180
Lines 21621 21621
==========================================
+ Hits 17051 17067 +16
+ Misses 3742 3736 -6
+ Partials 828 818 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR prevents client-side panics in append error handling by correctly accessing error messages from the result struct instead of a nil error variable during partial append failures.
Anything else
Couldn't find a clean way to simulate partial failures on a specific log stream in the test environment, so test coverage was not added for this fix.