added support for charge 2024 feat with additional GWF 2014/24 #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udpated settings added support for 2014/24 gwf since the dmg now is addtional damage die.
kakaroto
reviewed
Nov 26, 2024
| if(character.hasGreatWeaponFighting(2014)) { | ||
| charge_dmg += "ro<=2"; | ||
| } else if(character.hasGreatWeaponFighting(2024)) { | ||
| charge_dmg = charge_dmg.replace(/([0-9]*)d([0-9]+)([^\s+-]*)(.*)/g, (match, amount, faces, roll_mods, mods) => { |
There was a problem hiding this comment.
You don't need all this complex regexp, you know charge_dmg is 1d8, you can just do charge_dmg = "1d8min3" or use += safely, like for 2014 version
|
@kakaroto change done <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated settings
added support for 2014/24 gwf since the dmg now is addtional damage die.
Old charger feat
New Charger feat
tests
Great axe gwf 2014
Great axe gwf 2014
Great axe gwf 2024
polearms 2014 gwf 2024
polearms 2024 gwf 2024
polearms 2024 gwf 2014
polearms 2014 gwf 2014
Non-heavy weapon