Functional revert of "Signal different dirty bit for vertex buffer ch…

…ange." Seems to be causing rendering regressions in the Google Maps benchmark. Likely causing other serious regressions. Original CL: https://chromium-review.googlesource.com/c/angle/angle/+/1684294 Bug: angleproject:3256 Change-Id: I41608a3ce3c3267097b4c1c0a6f7450cf8a2f48f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1709756 Reviewed-by: Cody Northrop <[email protected]> Commit-Queue: Jamie Madill <[email protected]>
kakashidinho · Jul 19, 2019 · fb5c581 · fb5c581
1 parent 765ee7b
commit fb5c581
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/src/libANGLE/VertexArray.cpp b/src/libANGLE/VertexArray.cpp
@@ -477,15 +477,20 @@ ANGLE_INLINE void VertexArray::setVertexAttribPointerImpl(const Context *context
     attrib.pointer                 = pointer;
     attrib.vertexAttribArrayStride = stride;
 
-    if (bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride) &&
-        !attribDirty)
-    {
-        setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER_BUFFER);
-    }
-    else if (attribDirty)
-    {
-        setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
-    }
+    // "Pointer buffer" dirty bit disabled because of a bug. http://anglebug.com/3256
+    bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride);
+    setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
+    ANGLE_UNUSED_VARIABLE(attribDirty);
+
+    // if (bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride) &&
+    //    !attribDirty)
+    //{
+    //    setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER_BUFFER);
+    //}
+    // else if (attribDirty)
+    //{
+    //    setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
+    //}
 
     mState.mNullPointerClientMemoryAttribsMask.set(attribIndex,
                                                    boundBuffer == nullptr && pointer == nullptr);