Apply Guichan's changes from 5de1c0cbb341e45819ee5efcd8907e398568f0c7…

… (Sept 18th 2008)

http://code.google.com/p/guichan/issues/detail?id=72 and comments and code clean up.

TODO

@@ -1,4 +1,4 @@
-* Continue rebasing from 5de1c0cbb341e45819ee5efcd8907e398568f0c7
+* Continue rebasing from 3acee30c0bb2540b2104ee2f803d8cd2844af0b9
 * Add a focus listener interface.
 * Make focus apply synchronously.
 * Graphics and input objects for DirectX.

include/guisan/basiccontainer.hpp

@@ -119,6 +119,7 @@ namespace gcn
 
         virtual Widget *getWidgetAt(int x, int y);
 
+        virtual std::list<Widget*> getWidgetsIn(const Rectangle& area, Widget* ignore = NULL);
 
         // Inherited from DeathListener
 

include/guisan/text.hpp

@@ -58,24 +58,29 @@ namespace gcn
      * A utility class to ease working with text in widgets such as
      * TextBox and TextField. The class wraps common text operations
      * such as inserting and deleting text.
+     *
+     * @since 1.1.0
      */
     class GCN_CORE_DECLSPEC Text
     {
     public:
         /**
          * Constructor.
+         * @since 1.1.0
          */
         Text();
 
         /**
          * Constructor.
          *
          * @param content The content of the text.
+         * @since 1.1.0
          */
         Text(const std::string& content);
 
         /**
          * Destructor.
+         * @since 1.1.0
          */
         virtual ~Text();
 
@@ -84,13 +89,15 @@ namespace gcn
          * any previous text and reset the caret position.
          *
          * @param content The content of the text.
+         * @since 1.1.0
          */
         virtual void setContent(const std::string& text);
 
         /**
          * Gets the content of the text.
          *
          * @return The content of the text.
+         * @since 1.1.0
          */
         virtual std::string getContent() const;
 
@@ -99,6 +106,7 @@ namespace gcn
          *
          * @param row The row to set the text of.
          * @throws Exception when the row does not exist.
+         * @since 1.1.0
          */
         virtual void setRow(unsigned int row, const std::string& content);
 
@@ -107,6 +115,7 @@ namespace gcn
          * not change the current caret position.
          *
          * @param row The row to add.
+         * @since 1.1.0
          */
         virtual void addRow(const std::string& row);
 
@@ -116,13 +125,15 @@ namespace gcn
          * @param row The row to get the content of.
          * @return The content of a row.
          * @throws Exception when no such row exists.
+         * @since 1.1.0
          */
         virtual std::string getRow(unsigned int row) const;
 
         /**
          * Inserts a character at the current caret position.
          *
-         * @parameter character The character to insert.
+         * @param character The character to insert.
+         * @since 1.1.0
          */
         virtual void insert(int character);
 
@@ -137,14 +148,16 @@ namespace gcn
          * removed the row with the line feed will be merged
          * with the row above the line feed.
          *
-         * @numberOfCharacters The number of characters to remove.
+         * @param numberOfCharacters The number of characters to remove.
+         * @since 1.1.0
          */
         virtual void remove(int numberOfCharacters);
 
         /**
          * Gets the caret position.
          *
-         * @return The caret position;
+         * @return The caret position.
+         * @since 1.1.0
          */
         virtual int getCaretPosition() const;
 
@@ -153,6 +166,7 @@ namespace gcn
          * clamp to the dimension of the content.
          *
          * @param position The position of the caret.
+         * @since 1.1.0
          */
         virtual void setCaretPosition(int position);
 
@@ -163,20 +177,23 @@ namespace gcn
          * @param x The x coordinate of the caret.
          * @param y The y coordinate of the caret.
          * @param font The font to use when calculating the position.
+         * @since 1.1.0
          */
         virtual void setCaretPosition(int x, int y, Font* font);
 
         /**
          * Gets the column the caret is currently in.
          *
          * @return The column the caret is currently in.
+         * @since 1.1.0
          */
         virtual int getCaretColumn() const;
 
         /**
          * Gets the row the caret is currently in.
          *
          * @return The row the caret is currently in.
+         * @since 1.1.0
          */
         virtual int getCaretRow() const;
 
@@ -185,6 +202,7 @@ namespace gcn
          * will be clamp to the current row.
          *
          * @param column The column the caret should be in.
+         * @since 1.1.0
          */
         virtual void setCaretColumn(int column);
 
@@ -198,6 +216,7 @@ namespace gcn
          * column.
          *
          * @param row The row the caret should be in.
+         * @since 1.1.0
          */
         virtual void setCaretRow(int row);
 
@@ -206,6 +225,7 @@ namespace gcn
          *
          * @param font The font to use when calculating the x coordinate.
          * @return The x coorinate of the caret in pixels.
+         * @since 1.1.0
          */
         virtual int getCaretX(Font* font) const;
 
@@ -214,6 +234,7 @@ namespace gcn
          *
          * @param font The font to use when calculating the y coordinate.
          * @return The y coorinate of the caret in pixels.
+         * @since 1.1.0
          */
         virtual int getCaretY(Font* font) const;
 
@@ -223,6 +244,7 @@ namespace gcn
          *
          * @param font The font to use when calculating the dimension.
          * @return The dimension in pixels of the text given a font.
+         * @since 1.1.0
          */
         virtual Rectangle getDimension(Font* font) const;
 
@@ -233,6 +255,7 @@ namespace gcn
          *
          * @param font The font to use when calculating the dimension.
          * @return The dimension of the caret.
+         * @since 1.1.0
          */
         virtual Rectangle getCaretDimension(Font* font) const;
 
@@ -242,13 +265,15 @@ namespace gcn
          *
          * @param row The row to get the width of.
          * @return The width in pixels of a row.
+         * @since 1.1.0
          */
         virtual int getWidth(int row, Font* font) const;
 
         /**
          * Gets the maximum row the caret can be in.
          *
          * @return The maximum row the caret can be in.
+         * @since 1.1.0
          */
         virtual unsigned int getMaximumCaretRow() const;
 
@@ -257,20 +282,23 @@ namespace gcn
          *
          * @param row The row of the caret.
          * @return The maximum column of a row the caret can be in.
+         * @since 1.1.0
          */
         virtual unsigned int getMaximumCaretRow(unsigned int row) const;
 
         /**
          * Gets the number of rows in the text.
          *
          * @return The number of rows in the text.
+         * @since 1.1.0
          */
         virtual unsigned int getNumberOfRows() const;
 
         /**
          * Gets the number of characters in the text.
          *
          * @return The number of characters in the text.
+         * @since 1.1.0
          */
         virtual unsigned int getNumberOfCharacters() const;
 
@@ -281,6 +309,7 @@ namespace gcn
          * @param row The row to get the number of characters in.
          * @return The number of characters in a certain row, or zero
          *         if the row does not exist.
+         * @since 1.1.0
          */
         virtual unsigned int getNumberOfCharacters(unsigned int row) const;
 

include/guisan/widget.hpp

@@ -821,7 +821,7 @@ namespace gcn
         virtual bool isModalMouseInputFocused() const;
 
         /**
-         * Gets a widget from a certain position in the widget.
+         * Gets a widget at a certain position in the widget.
          * This function is used to decide which gets mouse input,
          * thus it can be overloaded to change that behaviour.
          *
@@ -836,6 +836,19 @@ namespace gcn
          */
         virtual Widget *getWidgetAt(int x, int y);
 
+        /**
+         * Gets all widgets inside a certain area of the widget.
+         *
+         * NOTE: This always returns an empty list if the widget is not
+         *       a container.
+         *
+         * @param area The area to check.
+         * @param ignore If supplied, this widget will be ignored.
+         * @return A list of widgets. An empty list if no widgets was found.
+         * @since 1.1.0
+         */
+        virtual std::list<Widget*> getWidgetsIn(const Rectangle& area, Widget* ignore = NULL);
+
         /**
          * Gets the mouse listeners of the widget.
          *

src/basiccontainer.cpp

@@ -453,4 +453,18 @@ namespace gcn
 
         setSize(w, h);
     }
+
+    std::list<Widget*> BasicContainer::getWidgetsIn(const Rectangle& area, Widget* ignore)
+    {
+        std::list<Widget*> result;
+
+        for (std::list<Widget*>::const_iterator iter = mWidgets.begin(); iter != mWidgets.end(); iter++)
+        {
+            Widget* widget = (*iter);
+            if (ignore != widget && widget->getDimension().isIntersecting(area))
+                result.push_back(widget);
+        }
+
+        return result;
+    }
 }

src/text.cpp

@@ -239,7 +239,7 @@ namespace gcn
         unsigned int total = 0;
         for (unsigned int i = 0; i < mRows.size(); i++)
         {
-            if (position <= total + (int) mRows[i].size())
+            if (position <= (int) (total + mRows[i].size()))
             {
                 mCaretRow = i;
                 mCaretColumn = position - total;
@@ -281,7 +281,7 @@ namespace gcn
     {
         if (mRows.empty() || column < 0)
             mCaretColumn = 0;
-        else if (column > mRows[mCaretRow].size())
+        else if (column > (int) mRows[mCaretRow].size())
             mCaretColumn = mRows[mCaretRow].size();
         else
             mCaretColumn = column;
@@ -293,7 +293,7 @@ namespace gcn
     {
         if (mRows.empty() || row < 0)
             mCaretRow = 0;
-        else if (row >= mRows.size())
+        else if (row >= (int) mRows.size())
             mCaretRow = mRows.size() - 1;
         else
             mCaretRow = row;

src/widget.cpp

@@ -759,4 +759,9 @@ namespace gcn
 
         return widget;
     }
+
+    std::list<Widget*> Widget::getWidgetsIn(const Rectangle& area, Widget* ignore)
+    {
+        return std::list<Widget*>();
+    }
 }