Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const where possible #79

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Use const where possible #79

merged 8 commits into from
Sep 12, 2024

Conversation

midwan
Copy link
Collaborator

@midwan midwan commented Sep 12, 2024

Use const where possible

@Jarod42
Copy link
Collaborator

Jarod42 commented Sep 12, 2024

src/genericinput.cpp: In member function ‘virtual gcn::KeyInput gcn::GenericInput::dequeueKeyInput()’:
src/genericinput.cpp:146:15: error: ‘KeyInputkeyInput’ does not name a type
146 | const KeyInputkeyInput = mKeyInputQueue.front();

Jarod42
Jarod42 requested changes Sep 12, 2024
View reviewed changes
src/sdl/sdl2graphics.cpp Outdated Show resolved Hide resolved
src/sdl/sdlgraphics.cpp Outdated Show resolved Hide resolved
src/widgets/checkbox.cpp Outdated Show resolved Hide resolved
Jarod42
Jarod42 reviewed Sep 12, 2024
View reviewed changes
src/sdl/sdlgraphics.cpp Outdated Show resolved Hide resolved
@midwan midwan requested a review from Jarod42 September 12, 2024 15:49
@midwan midwan merged commit a46b5e1 into master Sep 12, 2024
4 checks passed
@midwan midwan deleted the const-fixes branch September 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarod42 Jarod42 Jarod42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midwan @Jarod42