cargo clippy

src/commands/delete_files.rs

@@ -44,10 +44,9 @@ fn delete_files(
     permanently: bool,
 ) -> AppResult {
     let file_op = FileOperation::Delete;
-    let options = {
-        let mut options = FileOperationOptions::default();
-        options.permanently = !app_state.config.use_trash || permanently;
-        options
+    let options = FileOperationOptions {
+        permanently: !app_state.config.use_trash || permanently,
+        ..Default::default()
     };
 
     let dest = path::PathBuf::new();

src/config/theme/tab.rs

@@ -70,10 +70,10 @@ impl From<TabThemeCharsRaw> for TabThemeChars {
 #[derive(Clone, Debug)]
 pub struct TabThemeCharsInference {
     pub tab_divider_length: usize,
-    pub tab_prefix_i_length: usize,
-    pub tab_postfix_i_length: usize,
-    pub tab_prefix_a_length: usize,
-    pub tab_postfix_a_length: usize,
+    pub _tab_prefix_i_length: usize,
+    pub _tab_postfix_i_length: usize,
+    pub _tab_prefix_a_length: usize,
+    pub _tab_postfix_a_length: usize,
     pub scroll_front_static_length: usize,
     pub scroll_back_static_length: usize,
     pub active_tab_extra_width: usize,
@@ -84,10 +84,10 @@ impl TabThemeCharsInference {
     fn from_chars(chars: &TabThemeChars) -> Self {
         Self {
             tab_divider_length: chars.divider.width(),
-            tab_prefix_i_length: chars.prefix_i.width(),
-            tab_prefix_a_length: chars.prefix_a.width(),
-            tab_postfix_i_length: chars.postfix_i.width(),
-            tab_postfix_a_length: chars.postfix_a.width(),
+            _tab_prefix_i_length: chars.prefix_i.width(),
+            _tab_prefix_a_length: chars.prefix_a.width(),
+            _tab_postfix_i_length: chars.postfix_i.width(),
+            _tab_postfix_a_length: chars.postfix_a.width(),
             scroll_front_static_length: chars.scroll_front_prefix.width()
                 + chars.scroll_front_postfix.width()
                 + chars.scroll_front_prestring.width()

src/preview/preview_file.rs

@@ -23,7 +23,7 @@ pub struct FilePreview {
     pub status: std::process::ExitStatus,
     pub output: String,
     pub index: usize,
-    pub modified: time::SystemTime,
+    pub _modified: time::SystemTime,
 }
 
 impl std::convert::From<Output> for FilePreview {
@@ -35,7 +35,7 @@ impl std::convert::From<Output> for FilePreview {
         Self {
             status,
             output: s2,
-            modified,
+            _modified: modified,
             index: 0,
         }
     }

src/types/command/impl_appexecute.rs

@@ -51,10 +51,11 @@ impl AppExecute for Command {
             Self::CopyFilePath { all_selected: true } => file_ops::copy_filepath(app_state, true),
             Self::CopyDirPath => file_ops::copy_dirpath(app_state),
             Self::SymlinkFiles { relative } => {
-                let mut options = FileOperationOptions::default();
-                options.symlink = true;
-                options.symlink_relative = *relative;
-
+                let options = FileOperationOptions {
+                    _symlink: true,
+                    symlink_relative: *relative,
+                    ..Default::default()
+                };
                 file_ops::create_io_task(app_state, FileOperation::Symlink, options)
             }
             Self::PasteFiles { options } => file_ops::create_io_paste_task(app_state, *options),

src/types/io/file_operation.rs

@@ -45,7 +45,7 @@ impl std::fmt::Display for FileOperation {
 #[derive(Clone, Copy, Debug, Default)]
 pub struct FileOperationOptions {
     // symlink
-    pub symlink: bool,
+    pub _symlink: bool,
     pub symlink_relative: bool,
 
     // cut, copy

src/types/state/preview_state.rs

@@ -239,7 +239,6 @@ impl PreviewState {
     ///
     /// This function shall be called each time a change of Joshuto's preview can be expected.
     /// (As of now, it's called in each cycle of the main loop.)
-
     fn backend_rect(config: &AppConfig, backend: &AppBackend) -> io::Result<Rect> {
         let size = backend.terminal_ref().size()?;
         let area = Rect {

src/ui/tab_list_builder.rs

@@ -235,11 +235,7 @@ fn factor_tab_bar_sequence(
     //##         (=> we need scrolling)
     //####################################################################
     let scroll_tags_width = config.inference.calc_scroll_tags_width(tab_num);
-    let scrollable_width = if scroll_tags_width > available_width {
-        0
-    } else {
-        available_width - scroll_tags_width
-    };
+    let scrollable_width = available_width.saturating_sub(scroll_tags_width);
 
     let carousel_labels = if all_labels_as_long[current_index].width()
         + config.inference.active_tab_extra_width

src/ui/views/tui_command_menu.rs

@@ -24,7 +24,7 @@ impl<'a> TuiCommandMenu<'a> {
     }
 }
 
-impl<'a> Widget for TuiCommandMenu<'a> {
+impl Widget for TuiCommandMenu<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         TuiView::new(self.app_state).render(area, buf);
 

src/ui/views/tui_folder_view.rs

@@ -27,7 +27,7 @@ impl<'a> TuiFolderViewBorders<'a> {
     }
 }
 
-impl<'a> Widget for TuiFolderViewBorders<'a> {
+impl Widget for TuiFolderViewBorders<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let block = Block::default().borders(Borders::ALL);
         let inner = block.inner(area);
@@ -113,7 +113,7 @@ impl<'a> TuiFolderView<'a> {
     }
 }
 
-impl<'a> Widget for TuiFolderView<'a> {
+impl Widget for TuiFolderView<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let display_options = &self.app_state.config.display_options;
 

src/ui/views/tui_hsplit_view.rs

@@ -21,7 +21,7 @@ impl<'a> TuiHSplitView<'a> {
     }
 }
 
-impl<'a> Widget for TuiHSplitView<'a> {
+impl Widget for TuiHSplitView<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let tab_state = self.app_state.state.tab_state_ref();
 

src/ui/views/tui_minimal_view.rs

@@ -21,7 +21,7 @@ impl<'a> TuiMinimalView<'a> {
     }
 }
 
-impl<'a> Widget for TuiMinimalView<'a> {
+impl Widget for TuiMinimalView<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let tab_state = self.app_state.state.tab_state_ref();
 

src/ui/views/tui_progress_view.rs

@@ -21,7 +21,7 @@ impl<'a> TuiProgressView<'a> {
     }
 }
 
-impl<'a> Widget for TuiProgressView<'a> {
+impl Widget for TuiProgressView<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let f_size = area;
 

src/ui/views/tui_view.rs

@@ -20,7 +20,7 @@ impl<'a> TuiView<'a> {
     }
 }
 
-impl<'a> Widget for TuiView<'a> {
+impl Widget for TuiView<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let display_options = &self.app_state.config.display_options;
         match display_options.mode {

src/ui/views/tui_worker_view.rs

@@ -15,7 +15,7 @@ impl<'a> TuiWorkerView<'a> {
     }
 }
 
-impl<'a> Widget for TuiWorkerView<'a> {
+impl Widget for TuiWorkerView<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         if area.height == 0 {
             return;

src/ui/widgets/tui_dirlist.rs

@@ -26,7 +26,7 @@ impl<'a> TuiDirList<'a> {
     }
 }
 
-impl<'a> Widget for TuiDirList<'a> {
+impl Widget for TuiDirList<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         if area.width < 4 || area.height < 1 {
             return;

src/ui/widgets/tui_dirlist_detailed.rs

@@ -47,7 +47,7 @@ impl<'a> TuiDirListDetailed<'a> {
     }
 }
 
-impl<'a> Widget for TuiDirListDetailed<'a> {
+impl Widget for TuiDirListDetailed<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         if area.width < 4 || area.height < 1 {
             return;

src/ui/widgets/tui_file_preview.rs

@@ -62,7 +62,7 @@ impl<'a> TuiFilePreview<'a> {
     }
 }
 
-impl<'a> Widget for TuiFilePreview<'a> {
+impl Widget for TuiFilePreview<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         self.render_text_preview(area, buf, self.preview.output.as_str());
     }

src/ui/widgets/tui_footer.rs

@@ -24,7 +24,7 @@ impl<'a> TuiFooter<'a> {
     }
 }
 
-impl<'a> Widget for TuiFooter<'a> {
+impl Widget for TuiFooter<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let visual_mode_style = Style::default().fg(Color::Black).bg(Color::LightRed);
         let mode_style = Style::default().fg(Color::Cyan);

src/ui/widgets/tui_help.rs

@@ -38,7 +38,7 @@ impl<'a> TuiHelp<'a> {
     }
 }
 
-impl<'a> Widget for TuiHelp<'a> {
+impl Widget for TuiHelp<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         // Subtracting 2 because we'll draw a title at the top and some
         // additional information at the bottom of the page

src/ui/widgets/tui_io_tasks.rs

@@ -17,7 +17,7 @@ impl<'a> TuiIoTasks<'a> {
     }
 }
 
-impl<'a> Widget for TuiIoTasks<'a> {
+impl Widget for TuiIoTasks<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         if area.height < 7 {
             return;
@@ -64,7 +64,7 @@ impl<'a> TuiCurrentWorker<'a> {
     }
 }
 
-impl<'a> Widget for TuiCurrentWorker<'a> {
+impl Widget for TuiCurrentWorker<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let top = area.top();
         let left = area.left();
@@ -121,7 +121,7 @@ impl<'a> TuiWorkerQueue<'a> {
     }
 }
 
-impl<'a> Widget for TuiWorkerQueue<'a> {
+impl Widget for TuiWorkerQueue<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let top = area.top();
         let left = area.left();

src/ui/widgets/tui_menu.rs

@@ -17,7 +17,7 @@ impl<'a> TuiMenu<'a> {
     }
 }
 
-impl<'a> Widget for TuiMenu<'a> {
+impl Widget for TuiMenu<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let style = Style::default().fg(Color::Reset).bg(Color::Reset);
 

src/ui/widgets/tui_message.rs

@@ -14,7 +14,7 @@ impl<'a> TuiMessage<'a> {
     }
 }
 
-impl<'a> Widget for TuiMessage<'a> {
+impl Widget for TuiMessage<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         if area.width < 4 || area.height < 1 {
             return;

src/ui/widgets/tui_text.rs

@@ -94,7 +94,7 @@ impl<'a> TuiMultilineText<'a> {
     }
 }
 
-impl<'a> Widget for TuiMultilineText<'a> {
+impl Widget for TuiMultilineText<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let area_left = area.left();
         let area_top = area.top();

src/ui/widgets/tui_topbar.rs

@@ -21,7 +21,7 @@ impl<'a> TuiTopBar<'a> {
     }
 }
 
-impl<'a> Widget for TuiTopBar<'a> {
+impl Widget for TuiTopBar<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let name_width = USERNAME.as_str().len() + HOSTNAME.as_str().len() + 2;