Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of negations in applications array #9

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Commits on Jul 26, 2022

  1. Fix propagation of negations

    While _negations in the Applications type was being properly
    initialised, it wasn't copied on merges. This simple fix merely extends
    the list, which should work just fine i.e. I don't think it makes sense
    to ensure uniqueness here.
    
    Closes: madduck#44
    Signed-off-by: martin f. krafft <[email protected]>
    madduck authored and simu committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    80d6d15 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Don't insert previously negated items in Applications.append_if_new()

    We add logic in `Applications.append_if_new()` to only insert
    non-negated items if they aren't already on our internal negation list.
    
    Additionally, we drop items from the negation list, once we've applied
    the negation once either in `append_if_new()` or in `merge_unique()` so
    that patterns like adding, then removing and then adding an item again
    have the expected result of the item being present in the final list.
    
    This fixes the issue where it wasn't possible to preemptively remove an
    entry from the applications list in a multi-dimensional hierarchy, e.g.
    in a [Commodore] global defaults repository where we may want to exclude
    applications for a certain Kubernetes distribution regardless of the
    cloud on which a cluster with that distribution is running.
    
    [Commodore]: https://syn.tools/commodore
    simu committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    44065c8 View commit details
    Browse the repository at this point in the history