(do not merge yet) WIP port to use kappa next #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this to be able to experiment if kappa-drive would be easy enough to port to the current kappa-core WIP rewrite.
Do not merge! This PR is just so that the code is out somewhere.
Details on why this is needed if the kappa-core next branch should be merged:
kappa-view-kv uses the internal
kappa._logsproperty that is the multifeed instance. This of course cannot work if kappa-core is not hardwired to multifeed. Instead, kappa-view-kv now assumes that its source in the kappa exposes an API methodfeed(key)that returns a hypercore instance for a key. Thisfeedmethod is implemented both for the multifeed and corestore sources in kappa-core.