This repository has been archived by the owner on Dec 28, 2018. It is now read-only.
[DO NOT MERGE] feat(GUItoolkit): introduce office-ui-fabric-react #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuharuohzeki
commented
Oct 13, 2016
| @@ -27,6 +27,7 @@ | |||
| "pretty": true, | |||
| "preserveConstEnums": true, | |||
| "removeComments": false, | |||
| "skipLibCheck": true, // Avoid the compile error with office-ui-fabric-react | |||
There was a problem hiding this comment.
We need to enable this option until microsoft/fluentui#382 will be fixed
…fice-ui-fabric-react
tetsuharuohzeki
force-pushed
the
office-fabric-ui
branch
from
c2855f5
to
f25cdc3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Office-UI-Fabric for react.
Pros
thus we don't need to think about d.ts.
So I thought we can handle this easily.
Cons
They have the criminal record as known as WinJS :/
This change is