Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions cache_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package ccache

import (
"fmt"
"math/rand"
"sort"
"strconv"
Expand Down Expand Up @@ -413,14 +414,15 @@ func Test_ConcurrentClearAndSet(t *testing.T) {
var wg sync.WaitGroup

cache := New(Configure[string]())
wg.Add(1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r := func() {
for !stop.Load() {
cache.Set("a", "a", time.Minute)
}
wg.Done()
}
go r()
wg.Add(1)

cache.Clear()
stop.Store(true)
wg.Wait()
Expand All @@ -432,20 +434,26 @@ func Test_ConcurrentClearAndSet(t *testing.T) {
// list is maintained by the background worker. This can create a period
// where the two are out of sync. Even SyncUpdate is helpless here, since
// it can only sync what's been written to the buffers.
for i := 0; i < 10; i++ {
assertEventually(t, func() bool {
expectedCount := 0
if cache.list.Head != nil {
expectedCount = 1
}
actualCount := cache.ItemCount()
if expectedCount == actualCount {
return
}
time.Sleep(time.Millisecond)
return expectedCount == actualCount
}, 100, 50*time.Millisecond, fmt.Sprintf("cache list and lookup are not consistent in iteration %v", i))
Copy link
Contributor Author

@miparnisari miparnisari Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter what numbers I pass here, i always get a failure. @karlseguin are you sure this test is correct? I'm not familiar with the internals very well to understand what you are trying to test.

}
}

func assertEventually(t *testing.T, assertion func() bool, maxRetry int, waitTime time.Duration, failmessage string) {
for i := 0; i < maxRetry; i++ {
if assertion() {
return
}
t.Errorf("cache list and lookup are not consistent")
t.FailNow()
time.Sleep(waitTime)
}
// log and fail
t.Fatalf(failmessage)
}

func BenchmarkFrequentSets(b *testing.B) {
Expand Down
Loading