Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sad #36

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

sad #36

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions .github/actions/lint/action.yml

This file was deleted.

15 changes: 10 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,20 @@ jobs:
artifact_name: ${{ needs.setup.outputs.vsix_artifact_name }}

lint:
name: Lint
if: github.repository == 'microsoft/vscode-python'
name: Lintasd
runs-on: ubuntu-latest
steps:
- name: Checkout
- name: Checkout Actions
uses: actions/checkout@v3
with:
repository: 'microsoft/vscode-python-engineering'
path: ./actions
- name: Install Actions
run: npm install --production --prefix ./actions
- name: Checkout Actions
uses: actions/checkout@v3

- name: Lint
uses: ./.github/actions/lint
uses: ./actions/lint
with:
node_version: ${{ env.NODE_VERSION }}

Expand Down
68 changes: 0 additions & 68 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

20 changes: 8 additions & 12 deletions .github/workflows/community-feedback-auto-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,14 @@ jobs:
issues: write

steps:
- name: Check For Existing Comment
uses: peter-evans/find-comment@v2
id: finder
- name: Checkout Actions
uses: actions/checkout@v3
with:
issue-number: ${{ github.event.issue.number }}
comment-author: 'github-actions[bot]'
body-includes: Thanks for the feature request! We are going to give the community

- name: Add Community Feedback Comment
if: steps.finder.outputs.comment-id == ''
uses: peter-evans/create-or-update-comment@v3
repository: 'microsoft/vscode-python-engineering'
path: ./actions
- name: Install Actions
run: npm install --production --prefix ./actions
- name: Add Community Feedback Comment if applicable
uses: ./actions/community-feedback-auto-comment
with:
issue-number: ${{ github.event.issue.number }}
body: |
Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.
63 changes: 12 additions & 51 deletions .github/workflows/issue-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,55 +18,16 @@ jobs:
name: "Add 'triage-needed' and remove unrecognizable labels & assignees"
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
- name: Checkout Actions
uses: actions/checkout@v3
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const result = await github.rest.issues.listLabelsOnIssue({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
})
const labels = result.data.map((label) => label.name)
const hasNeedsOrTPI = labels.some((label) => (label.startsWith('needs') || label === 'testplan-item' || label.startsWith('iteration-plan') || label === 'release-plan'))

if (!hasNeedsOrTPI) {
console.log('This issue is not labeled with a "needs __", "iteration-plan", "release-plan", or the "testplan-item" label; add the "triage-needed" label.')

github.rest.issues.addLabels({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
labels: ['triage-needed']
})
} else {
console.log('This issue already has a "needs __", "iteration-plan", "release-plan", or the "testplan-item" label, do not add the "triage-needed" label.')
}
const knownTriagers = ${{ env.TRIAGERS }}
const currentAssignees = await github.rest.issues
.get({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
})
.then((result) => result.data.assignees.map((a) => a.login));
console.log('Known triagers:', JSON.stringify(knownTriagers));
console.log('Current assignees:', JSON.stringify(currentAssignees));
const assigneesToRemove = currentAssignees.filter(a => !knownTriagers.includes(a));
console.log('Assignees to remove:', JSON.stringify(assigneesToRemove));
github.rest.issues.removeAssignees({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
assignees: assigneesToRemove,
});
const knownLabels = ${{ env.REPO_LABELS }}
for( const label of labels) {
if (!knownLabels.includes(label)) {
await github.rest.issues.deleteLabel({
owner: context.repo.owner,
repo: context.repo.repo,
name: label,
})
}
}
repository: 'microsoft/vscode-python-engineering'
path: ./actions
- name: Install Actions
run: npm install --production --prefix ./actions
- name: "Add 'triage-needed' and remove unrecognizable labels & assignees"
uses: ./actions/issue-labels
with:
triagers: ${{ env.TRIAGERS }}
token: ${{secrets.GITHUB_TOKEN}}
repo_labels: ${{ env.REPO_LABELS }}
15 changes: 10 additions & 5 deletions .github/workflows/lock-issues.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,14 @@ jobs:
lock-issues:
runs-on: ubuntu-latest
steps:
- uses: dessant/lock-threads@v4
- name: Checkout Actions
uses: actions/checkout@v3
with:
github-token: ${{ github.token }}
issue-inactive-days: '30'
process-only: 'issues'
log-output: true
repository: 'microsoft/vscode-python-engineering'
path: ./actions
- name: Install Actions
run: npm install --production --prefix ./actions
- name: 'Lock Issues'
uses: ./actions/lock-issues
with:
token: ${{ github.token }}
Loading