Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create intermedieate directories for GEOSERVER_CONTEXT_ROOT #553

Merged
merged 1 commit into from
Aug 9, 2023
Merged

create intermedieate directories for GEOSERVER_CONTEXT_ROOT #553

merged 1 commit into from
Aug 9, 2023

Conversation

m4ci3k2
Copy link
Contributor

@m4ci3k2 m4ci3k2 commented Aug 9, 2023

To support multipart CONTEXT_ROOT (for example /prefix/geoserver) the directory up to the last past needs to be created before moving the files.

@m4ci3k2 @mz2478318291
create intermedieate directories for GEOSERVER_CONTEXT_ROOT
9303e11 
to support multipart CONTEXT_ROOT (for example /prefix/geoserver) the directory up to the last past needs to be created
NyakudyaA
NyakudyaA reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@NyakudyaA NyakudyaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a test for this i.e copy the login logic and add a new test

@NyakudyaA NyakudyaA merged commit 314f0a8 into kartoza:develop Aug 9, 2023
7 checks passed
@aceenprsu aceenprsu mentioned this pull request Sep 1, 2023
Closed
@aceenprsu aceenprsu mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyakudyaA NyakudyaA NyakudyaA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4ci3k2 @NyakudyaA