-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select crs #31
Select crs #31
Conversation
could you test this PR is it works as you expecting?? @NyakudyaA |
Ok I am on it now. |
@NyakudyaA sorry, I've just made a patch for this PR, you can pull it again. Thanks! |
ok. But just to be sure how does the selected CRS affect the database operations |
@@ -299,6 +302,8 @@ def refresh_layers(self): | |||
required_layer.layer = layer | |||
self.iface.legendInterface().setLayerVisible( | |||
layer, True) | |||
if self.crs: | |||
layer.setCrs(self.crs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. But just to be sure how does the selected CRS affect the database operations
@NyakudyaA here, we will set the crs to the selected crs as soon as the layers are added by the plugin to the canvas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. That's fine. We assume that the user selects a CRS that corresponds to his database in the backend. Later we might need to add rules to check what database CRS has already been assigned to a table and compare this with the selected CRS so that a user can not select a CRS that is not the same as his database
@NyakudyaA my bad, I just made another patch for that. Sent from my LGE Nexus 5 using FastHub |
So from an earlier discussion with Gavin, the select CRS need to obey the following rules.
You could run a sql statement like If the query return true for all the layers then we proceed to load them from the database.
|
@NyakudyaA could you test this again for me? |
issue #27 #6
we will check whether the selected db has cogo scheme in it. If it doesn't have the schema then we will give an option to set one.