-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dcas error handling #385
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 94.26% 94.33% +0.06%
==========================================
Files 250 252 +2
Lines 14098 14461 +363
==========================================
+ Hits 13290 13642 +352
- Misses 808 819 +11 ☔ View full report in Codecov by Sentry. |
@osundwajeff could you also add the export to csv/excel from the django admin page? maybe add it as another new ticket. |
@danangmassandy This is the PR with the failing test that needs to be looked at |
@osundwajeff it seems the error is because the crop-plan API tries to fetch all Farms, so your test farms might also get fetched. Could you add request parameters farm_ids in the request like below?
Please add the request parameters in the failed test below: |
I'll do that thanks @danangmassandy |
@mvmaltitz Just in case you are wondering about ticket #391, It has been merged already |
Fix: #317