delete export_genome_features_protein_to_fasta from spec and recompile #209
Conversation
| @@ -236,9 +236,6 @@ module GenomeFileUtil { | |||
| funcdef export_genome_as_gff(ExportParams params) | |||
| returns (ExportOutput output) authentication required; | |||
|
|
|||
| funcdef export_genome_features_protein_to_fasta(ExportParams params) | |||
There was a problem hiding this comment.
I assume no other model is using this function? We should probably mention this in RELEASE note.
There was a problem hiding this comment.
They can't be, the return var is output which is never initialized.
+1 on release notes though
There was a problem hiding this comment.
updated release notes 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 80.61% 80.86% +0.24%
==========================================
Files 11 11
Lines 3007 2994 -13
==========================================
- Hits 2424 2421 -3
+ Misses 583 573 -10 ☔ View full report in Codecov by Sentry. |
kbase.yml
Outdated
| 0.11.7 | ||
| 0.11.8 | ||
|
|
There was a problem hiding this comment.
0.11.7 isn't registered anywhere, there's no need for a version bump
There was a problem hiding this comment.
Release notes still have a version bump
There was a problem hiding this comment.
so I just add under [0.11.7]? But how do I update the corresponding date?
There was a problem hiding this comment.
yep. I'd just set the date to TBD for now then change it when you register
RELEASE_NOTES.md
Outdated
| @@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [0.11.8] - 2024-05-23 | |||
| export_genome_features_protein_to_fasta was removed from GenomeFileUtil.spec | |||
There was a problem hiding this comment.
| export_genome_features_protein_to_fasta was removed from GenomeFileUtil.spec | |
| Unusable `export_genome_features_protein_to_fasta` function was removed |
No description provided.