Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chartpress #7

Merged
merged 11 commits into from
Oct 7, 2024
Merged

add chartpress #7

merged 11 commits into from
Oct 7, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 4, 2024

Uses chartpress to render the chart on each push to main

The kbatch-proxy image is built here, so it is versioned with the chart, solving kbatch-dev/kbatch#42

With this, making a prelease would be:

  • (pep440) tag prerelease of kbatch (if needed)
  • update appVersion here to match kbatch version
  • publish prerelease tag here (does not need to match the kbatch package version)

@minrk minrk requested a review from yuvipanda October 7, 2024 06:35
@minrk minrk marked this pull request as ready for review October 7, 2024 06:36
@minrk
Copy link
Contributor Author

minrk commented Oct 7, 2024

@yuvipanda I think this is ready to review and test. I can't be 100% sure the publishing will work until it's merged. I tried to run it on my fork, but actions just never run there, despite triggers.

What do you think about separating chart version from appVersion? I think that really simplifies things, but then we have to pick an initial chart version that's not too confusing. I like to pick an arbitrary offset when things like this happens, like starting with 0.101. Or we could leave it at 0.5 and let them diverge naturally.

@minrk minrk changed the title [WIP] add chartpress add chartpress Oct 7, 2024
@yuvipanda
Copy link
Collaborator

@minrk letting them diverge is fine.

Or we could leave it at 0.5 and let them diverge naturally.

Let's do this?

You should merge this and iterate as feels appropriate to you!

@minrk minrk merged commit f1816fe into kbatch-dev:main Oct 7, 2024
3 checks passed
@minrk minrk deleted the chartpress branch October 7, 2024 10:31
@minrk
Copy link
Contributor Author

minrk commented Oct 7, 2024

After a couple fixes, successfully published kbatch-proxy-0.5.0-0.dev.git.34.h37ac17c. I think we're ready to make an 0.5.0b1 with this and kbatch-dev/kbatch#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants