Feature/plasmo #21
Open
Feature/plasmo #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced Bun test runner and JSDOM for DOM simulation in tests. - Added React Testing Library for improved component testing. - Updated package.json to include new dependencies: jsdom, @testing-library/react, and happy-dom. - Expanded unit tests for KyokuList component and refactored transfer tests. - Removed obsolete test setup file.
…onfiguration - Removed the manifest.ts file and migrated its settings to package.json for centralized management. - Organized content script settings to match specific URL patterns and included necessary permissions. - Updated documentation to reflect these changes and outline next steps for testing and implementation.
…tests - Added data-testid attributes to key elements in NAGAPanel for better testability. - Updated the component structure to include a title and improved button accessibility. - Introduced a new test suite for NAGAPanel, covering rendering, button functionality, and conditional rendering based on props. - Ensured the transfer button behaves correctly when disabled and verifies click events.
- Replaced chrome.storage.local with Plasmo's Storage class for better type safety and consistency. - Simplified error handling in transfer functions by removing custom TransferError class. - Updated NAGA transfer logic to use message handlers for improved communication between content scripts and popup. - Commented out unused styles and components in content scripts for clarity. - Enhanced the popup component to load data asynchronously from storage.
- Introduced NagaPanel component with enhanced UI for data preview and error handling. - Implemented handleNagaTransfer function to manage data transfer to NAGA, including validation and error responses. - Added validation utility to ensure NAGA data integrity before transfer. - Expanded i18n messages for better user feedback on errors and actions. - Created unit tests for NagaPanel and validation logic to ensure reliability. - Removed obsolete transfer tests to streamline the testing suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.