Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenFaas to kbrew registry #38

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Aug 5, 2021

Fixes #37

Hope it is right.

Kind regards,

How i tested it localy:

➜  kbrew-registry git:(main) ✗ cp recipes/openfaas.yaml /Users/dirien/.kbrew/registries/kbrew-dev/kbrew-registry/recipes/
➜  kbrew-registry git:(main) ✗ kbrew install openfaas                                                                    
🚀 Installing openfaas app...
Version: 8.0.2
Pre-install dependencies: 
Post-install dependencies: 
---
 ✓ Installing app openfaas in openfaas namespace 
➜  kbrew-registry git:(main) ✗ kbrew remove openfaas
🧹 Uninstalling openfaas app and its dependencies...
Dependencies: 
---
 ✓ Removing app openfaas from openfaas namespace 

recipes/openfaas.yaml Outdated Show resolved Hide resolved
@dirien
Copy link
Contributor Author

dirien commented Aug 5, 2021

@PrasadG193, can you have a look when you have time? Interessted if the recipe is okay so.

recipes/openfaas.yaml Outdated Show resolved Hide resolved
recipes/openfaas.yaml Outdated Show resolved Hide resolved
@sahil-lakhwani
Copy link
Contributor

@dirien Recipe LGTM. Is there a quick way to verify if the installation was correct? If there, it require some wait?

Co-authored-by: Prasad Ghangal <[email protected]>
@dirien
Copy link
Contributor Author

dirien commented Aug 9, 2021

hi @sahil-lakhwani , the web ui should appear on http://:8080. Depending on how long it take to pull the image and startup time of the service.

@sahil-lakhwani
Copy link
Contributor

hi @sahil-lakhwani , the web ui should appear on http://:8080. Depending on how long it take to pull the image and startup time of the service.

Ok, then I think there's no definitive way without waiting. We can go without that for now.

@dirien
Copy link
Contributor Author

dirien commented Aug 18, 2021

hi @sahil-lakhwani: Small ping 😄

@sahil-lakhwani
Copy link
Contributor

hey @dirien , I was out last till yesterday. Merging this. Thanks a lot!

@sahil-lakhwani sahil-lakhwani merged commit 05372b9 into kbrew-dev:main Aug 24, 2021
@dirien dirien deleted the openfaas branch August 26, 2021 11:14
@dirien
Copy link
Contributor Author

dirien commented Aug 26, 2021

@sahil-lakhwani great thanks. FYI @alexellis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipe: OpenFaas
4 participants