Make ApiRequest public and onsider discharge cap in remaining time calculation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbroulik
force-pushed
the
kbroulik/remaining-bat-cap
branch
3 times, most recently
from
c0b7b16 to
31d172e
Compare
There's no way this library will ever provide wrappers for every single API endpoint. Making ApiRequest public enables the user to issue custom requests while not having to worry about the authentication scheme of the API. This replaces the EndPoint enum with constexpr strings (source compatible for the most part) and let the caller set an arbitrary endpoint string if desired. A custom URL query can also be provided.
The battery is typically configured not to discharge below 10%, which skewes the remaining time calculation since there's an additional half-a-kilowatt or so remaining that will not acutally be used. Rather than introduce a fully-fledged wrapper around the getDisChargeConfigInfo (which also includes configurable time settings), just call it directly for this one particular use case.
kbroulik
force-pushed
the
kbroulik/remaining-bat-cap
branch
from
31d172e to
03ab05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no way this library will ever provide wrappers for
every single API endpoint. Making ApiRequest public enables
the user to issue custom requests while not having to worry
about the authentication scheme of the API.
This replaces the EndPoint enum with constexpr strings (source
compatible for the most part) and let the caller set an
arbitrary endpoint string if desired. A custom URL query
can also be provided.
systemstats: Consider discharge cap in remaining time calculation
The battery is typically configured not to discharge below 10%,
which skewes the remaining time calculation since there's an
additional half-a-kilowatt or so remaining that will not acutally
be used.
Rather than introduce a fully-fledged wrapper around the
getDisChargeConfigInfo (which also includes configurable time
settings), just call it directly for this one particular use case.