Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: make 'kpm run' supports mvs #478

Closed
wants to merge 6 commits into from

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Sep 9, 2024

This PR structure is too large, and will not be merged, it will be merged through several sub PRs.

[ ] - Split resolver, visitor from the package client to solve the problem of method namesake caused by the WithOption pattern in the same package.

[ ] - The new Update() interface with the mvs version currently lacks the capability to support all functions of the run command. This missing parts needs to be completed.

[ ] - Porting the run command to the new Update() interface with the mvs version requires adjusting some test cases.

[ ] - Unify different variable names such as IsVendor and EnableVendorMode that have the same meaning.

@zong-zhe zong-zhe added the enhancement New feature or request label Sep 9, 2024
@zong-zhe zong-zhe requested a review from Peefy September 9, 2024 07:53
@zong-zhe zong-zhe self-assigned this Sep 9, 2024
@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10823477085

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 306 of 490 (62.45%) changed or added relevant lines in 8 files are covered.
  • 89 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.09%) to 41.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/client.go 8 9 88.89%
pkg/downloader/source.go 0 3 0.0%
pkg/client/update.go 67 80 83.75%
pkg/downloader/downloader.go 0 28 0.0%
pkg/client/resolver.go 126 191 65.97%
pkg/client/visitor.go 99 173 57.23%
Files with Coverage Reduction New Missed Lines %
pkg/downloader/downloader.go 1 36.67%
pkg/client/visitor.go 1 53.16%
pkg/client/resolver.go 1 70.37%
pkg/client/update.go 1 81.97%
pkg/client/client.go 85 54.44%
Totals Coverage Status
Change from base Build 10735403800: -0.09%
Covered Lines: 3569
Relevant Lines: 8507

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants