Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable structured authentication config flag #3295

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Feb 13, 2025

Summary

Enables flag for structured authentication flag that was planned as a follow-up during 1.30 k8s update.
I have added also an example guide to our dex guide made by MJ to verify the functionality.

Related issue(s)

Fixes #3216

Release Notes

Enable structured authentication configuration from a file with —authentication-config flag.

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 13, 2025
@cnvergence cnvergence marked this pull request as ready for review February 13, 2025 11:35
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 13, 2025
@kcp-ci-bot
Copy link
Contributor

Hi @cnvergence. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@embik embik self-requested a review February 13, 2025 12:58
@embik
Copy link
Member

embik commented Feb 13, 2025

/ok-to-test

PR should have a release note since we're enabling a previously disabled flag.

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 13, 2025
@embik
Copy link
Member

embik commented Feb 13, 2025

/retest

known issue.

Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46a49184a86fbc77458b33f58e2357906da7f32e

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@kcp-ci-bot kcp-ci-bot merged commit 980ac52 into kcp-dev:main Feb 14, 2025
18 checks passed
@cnvergence cnvergence deleted the add-auth-config branch February 17, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: support for structured authentication config
3 participants