Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(license): put license files #17

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Nov 27, 2024

Resolves #16
Resolves #3

I think we often confuse because GitHub does not display the license here.

image

I believe this repository is licensed under Apache-2.0, because of written in

"license": "Apache-2.0",

So copied files from kdl-org/kdl-rs#87 with project name changes in NOTICE file

Checked the result with licensee 9.18.0

Before

License:        Apache-2.0
Matched files:  package.json
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     Apache-2.0

After

License:        Apache-2.0
Matched files:  LICENSE, package.json
LICENSE:
  Content hash:  bec905d850e7f5dc2e2db78a950d4a9db560a0b8
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       Apache-2.0
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     Apache-2.0

Motivation of these PRs

I have a PR for micro-editor as zyedidia/micro#3549 from https://github.com/kachick/micro-kdl
So I want to clarify I can refer these implementations 🙏

Copy link
Member

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, thanks :)

@zkat zkat merged commit 5162aba into kdl-org:main Nov 27, 2024
@kachick
Copy link
Contributor Author

kachick commented Nov 27, 2024

Thank you!

@kachick kachick deleted the put-license-file branch November 27, 2024 17:36
zkat pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License this repository? License?
2 participants