Prototype fix for CID uniqueness #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
approved these changes
Sep 6, 2023
kecnry
added a commit
that referenced
this pull request
Sep 6, 2023
* fix for CID uniqueness * fix missing phase_comp_lbl reference * fix for binning test --------- Co-authored-by: Kyle Conroy <[email protected]>
kecnry
added a commit
that referenced
this pull request
Sep 8, 2023
* fix for CID uniqueness * fix missing phase_comp_lbl reference * fix for binning test --------- Co-authored-by: Kyle Conroy <[email protected]>
kecnry
added a commit
that referenced
this pull request
Sep 14, 2023
* fix for CID uniqueness * fix missing phase_comp_lbl reference * fix for binning test --------- Co-authored-by: Kyle Conroy <[email protected]>
kecnry
added a commit
that referenced
this pull request
Sep 14, 2023
* fix for CID uniqueness * fix missing phase_comp_lbl reference * fix for binning test --------- Co-authored-by: Kyle Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to spacetelescope#28 in order to overcome some issues with glue
ComponentIDs encountered in the binning plugin implementation.This PR:
x_attduring binning (though maybe that logic should be in the ephemeris plugin on Data add?)ephem_componentinstead ofcomponentwhen the "component" is referring to the name of a periodic event in the system rather than a glue Data component.