Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook timeouts #731

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add webhook timeouts #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions keda/templates/webhooks/validatingconfiguration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ webhooks:
resources:
- scaledobjects
sideEffects: None
timeoutSeconds: 10
timeoutSeconds: {{ .Values.webhooks.timeoutSeconds | default 10 }}
- admissionReviewVersions:
- v1
clientConfig:
Expand All @@ -67,7 +67,7 @@ webhooks:
resources:
- triggerauthentications
sideEffects: None
timeoutSeconds: 10
timeoutSeconds: {{ .Values.webhooks.timeoutSeconds | default 10 }}
- admissionReviewVersions:
- v1
clientConfig:
Expand All @@ -91,5 +91,5 @@ webhooks:
resources:
- clustertriggerauthentications
sideEffects: None
timeoutSeconds: 10
timeoutSeconds: {{ .Values.webhooks.timeoutSeconds | default 10 }}
{{- end }}
2 changes: 2 additions & 0 deletions keda/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ webhooks:
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
# -- Timeout in seconds for KEDA admission webhooks
timeoutSeconds: 10
# -- Enable webhook to use host network, this is required on EKS with custom CNI
useHostNetwork: false
# -- Name of the KEDA admission webhooks
Expand Down
Loading