Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add support for FromEnv properties for connections #76

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

Sreemoyee26
Copy link
Contributor

@Sreemoyee26 Sreemoyee26 commented Dec 4, 2024

This PR replaces the connection and leaseConnection properties in the scaler metadata with connectionFromEnv and leaseConnectionFromEnv respectively. Instead of directly passing the connection string, user will be required to specify the name of the environment variable in the scale target container's environment that contains the Cosmos DB connection string.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes

  • Added new JSON properties: connectionFromEnv and leaseConnectionFromEnv in the scaler metadata.
  • Updated the unit tests accordingly.
  • Updated the scaled object YAML files and demo project Readme to test out these changes.

README.md Outdated Show resolved Hide resolved
@Sreemoyee26 Sreemoyee26 changed the title Adding Support for Functions on ACA Adding Support for FromEnv properties for Connections Dec 9, 2024
Copy link
Collaborator

@JatinSanghvi JatinSanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold before addressing the review comments as we need to think whether to remove support for connection property entirely from the next version of scaler image.

README.md Outdated Show resolved Hide resolved
src/Scaler.Tests/CosmosDbScalerServiceTests.cs Outdated Show resolved Hide resolved
deploy/deploy-scaledobject.yaml Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
deploy/deploy-scaledobject.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler/Services/ScalerMetadata.cs Outdated Show resolved Hide resolved
src/Scaler.Tests/CosmosDbScalerServiceTests.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@krishnajaju krishnajaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sreemoyee26 added 9 commits December 24, 2024 14:04
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
@JatinSanghvi JatinSanghvi changed the title Adding Support for FromEnv properties for Connections feat!: Add support for FromEnv properties for connections Dec 24, 2024
@JatinSanghvi JatinSanghvi merged commit 68635a0 into kedacore:main Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants