-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add support for FromEnv
properties for connections
#76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold before addressing the review comments as we need to think whether to remove support for connection
property entirely from the next version of scaler image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
Signed-off-by: Sreemoyee26 <[email protected]>
8602e5a
to
5743d92
Compare
FromEnv
properties for connections
This PR replaces the
connection
andleaseConnection
properties in the scaler metadata withconnectionFromEnv
andleaseConnectionFromEnv
respectively. Instead of directly passing the connection string, user will be required to specify the name of the environment variable in the scale target container's environment that contains the Cosmos DB connection string.Checklist
Fixes
connectionFromEnv
andleaseConnectionFromEnv
in the scaler metadata.