Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PollingInterval configurable in HTTPScaledObject #1252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spenhouet
Copy link
Contributor

Provide the PollingInterval of the ScaledObject as parameter in the HTTPScaledObject.

Checklist

Fixes #1251

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

ptal @zroubalik, I know you are not a big fan of duplicating fields between HTTPScaledObject and ScaledObject but imho this one also makes sense because the operator sets this to a hardcoded 15s and patches over any custom changes to the ScaledObject made by the user

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate proposal:

What if we just remove the hardcoded 15s and let it on ScaledObject?

This project is still beta so backwards compatibility is something we can ingore for certain cases and I think this one is a good one.

@JorTurFer
Copy link
Member

JorTurFer commented Feb 13, 2025

The add-on is connected to KEDA as external-push scaler, so the polling interval isn't so relevant indeed.
When there is a change on the "active" state, the add-on pushes the change automatically, so the activation/deactivation is notified instantly. About using the polling interval to cache metrics, I don't think that HTTP Add-on metrics should be cached

I don't have in my mind all the add-on details atm, but I think that it's more or less how I have described.

Which is the goal of changing the pollingInterval value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PollingInterval configuration to HTTPScaledObject
4 participants