Fix STOCKINFO tag generation for investment files #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OFX STOCKINFO tag should be repeated for each individual security.
OFX STOCKINFO tag should be closed for each individual security
|
Yeah, according to [this] you seem to be right.
Meanwhile, it looks like ofxstatement build got completely broken. I'll fix it in a separate PR. |
|
Thanks. I'm developing a plugin to import JSON brokerage exports from Schwab, and this was giving me fits testing the import into GNUCash. I'll have another couple minor PRs as I go. |
|
Could you please rebase this branch on master (to fix the build)? |
Done! |
Add STOCKINFO tags to start and end of every individual security.
Delete extraneous empty line so that Black won't throw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OFX STOCKINFO tags need to be closed and repeated for each individual security. Leaving the tag off leads to unexpected behavior in GNUCash (and potentially other software).