Handle additional types of investment transactions #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some investment transactions (e.g. INTEREST) there is no security, so don't add a blank <STOCKINFO> that will get rejected by Gnucash.
Total doesn't need more than 2 decimal places.
edwagner
changed the title
kedder
requested changes
Mar 4, 2024
edwagner
force-pushed
the
invest-statement-enhancements
branch
from
6ff1d3a
to
95a601f
Compare
For INTEREST, XFER, and other cash transactions that are not associated with a security, INVBANKTRAN is the appropriate transaction type. The body is like a bank transaction (STMTTRN), not an INVTRAN.
For share transfers, TRANSFER is the appropriate type with no trntype_detailed, no amount and an optional unit_price.
edwagner
force-pushed
the
invest-statement-enhancements
branch
from
95a601f
to
8c1112c
Compare
|
It looks like it was a mypy error. I'm pretty new to Python and I hadn't looked at the various checks your actions run. I've pushed an update that should pass both mypy and black. |
kedder
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of building a plugin to convert Charles Schwab JSON exports to OFX, and need to write out some additional types of investment transactions in a way that is consumable by Gnucash.
Hopefully most if this is additive (i.e. shouldn't negatively impact current behavior) with the exception of limiting the precision of the total to 2 decimal places. IIRC, more than two decimal places on the total caused a problem importing into Gnucash.