-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): Introduce DO_NO_TRACK
and KEDRO_DISABLE_TELEMETRY
#762
Conversation
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
DO_NO_TRACK
and KEDRO_DISABLE_TELEMETRY
DO_NO_TRACK
and KEDRO_DISABLE_TELEMETRY
kedro-telemetry/RELEASE.md
Outdated
@@ -1,4 +1,5 @@ | |||
# Upcoming release | |||
* Added `DO_NOT_TRACK` and `KEDOR_DISABLE_TELEMETRY` environment variables to skip telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added `DO_NOT_TRACK` and `KEDOR_DISABLE_TELEMETRY` environment variables to skip telemetry. | |
* Added `DO_NOT_TRACK` and `KEDRO_DISABLE_TELEMETRY` environment variables to skip telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I tested it locally and it works fine.
Signed-off-by: Nok <[email protected]>
CI error is irrelevant, suspect some changes caused by kedro-org/kedro#3883. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @noklam! I appreciate the flow where these environment variables take first priority only when they are set to True.
kedro-org#762) * add env var to skip telemetry Signed-off-by: Nok Lam Chan <[email protected]> * release note Signed-off-by: Nok Lam Chan <[email protected]> * update README Signed-off-by: Nok Lam Chan <[email protected]> * fix test Signed-off-by: Nok Lam Chan <[email protected]> * Change constant to tuple to avoid random test error Signed-off-by: Nok Lam Chan <[email protected]> * linting Signed-off-by: Nok Lam Chan <[email protected]> * fix typo Signed-off-by: Nok <[email protected]> --------- Signed-off-by: Nok Lam Chan <[email protected]> Signed-off-by: Nok <[email protected]> Co-authored-by: Dmitry Sorokin <[email protected]> Signed-off-by: Merel Theisen <[email protected]>
Description
Fix #728
Development notes
.telemetry
file.Checklist
RELEASE.md
file