Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kedro Viz Lite User Warnings #2058

Closed
1 task done
ravi-kumar-pilla opened this issue Aug 23, 2024 · 4 comments · Fixed by #2092
Closed
1 task done

Kedro Viz Lite User Warnings #2058

ravi-kumar-pilla opened this issue Aug 23, 2024 · 4 comments · Fixed by #2092
Assignees
Labels
Design: UX Design: Visual Design Issue: Feature Request Javascript Pull requests that update Javascript code Python Pull requests that update Python code

Comments

@ravi-kumar-pilla
Copy link
Contributor

Description

This ticket is to address next steps in #1966

  1. FE notice with a warning of missing imports suggestion from TD on Lightweight Kedro Viz implementation
  2. CLI showing a warning message with missing imports (already implemented but needs confirmation from design on the wording. @stephkaiser )
  3. MemoryDataset to custom ImportErrorDataset in-case of missing dataset dependencies in the metadata panel. Since the focus is mostly on flowchart, I am not sure if we should create a custom dataset or leave this as MemoryDataset. (need to discuss this during backlog grooming)

Context

We mocked missing dependencies in Kedro project when users run kedro viz --lite. This ticket aims at letting the users aware of the mocked dependencies both in UI and CLI

Possible Implementation

  1. In CLI, have a logger warning message to inform users of the missing dependencies. Example:
[08/23/24 16:33:59] WARNING  Kedro-Viz has mocked the following             data_loader.py:173
                             dependencies for lite-mode.                                      
                             ['sklearn.base', 'matplotlib.pyplot',                            
                             'matplotlib', 'seaborn', 'PIL',                                  
                             'sklearn.model_selection', 'sklearn',                            
                             'sklearn.metrics']                                               
                             In order to get a complete experience of Viz,                    
                             please install the missing Kedro project                         
                             dependencies 
  1. In UI, have a hidden banner or something similar to this website and Kedro theme

  2. Leave the MemoryDataset as-is or implement a custom dataset and discuss on what all functionalities to include in the dataset (mostly leaving the bare-minimum) to show up in metadata panel

Checklist

  • Include labels so that we can categorise your feature request
@ravi-kumar-pilla ravi-kumar-pilla added Design: UX Issue: Feature Request Javascript Pull requests that update Javascript code Python Pull requests that update Python code labels Aug 23, 2024
@ravi-kumar-pilla ravi-kumar-pilla moved this to Inbox in Kedro-Viz Aug 23, 2024
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Sep 2, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Sep 2, 2024
@ravi-kumar-pilla
Copy link
Contributor Author

Hi @rashidakanchwala and @stephkaiser ,

Based on our discussion last week about the CLI message for missing dependencies in --lite mode -

Current message displays as -

[08/23/24 16:33:59] WARNING  Kedro-Viz has mocked the following             data_loader.py:173
                             dependencies for lite-mode.                                      
                             ['sklearn.base', 'matplotlib.pyplot',                            
                             'matplotlib', 'seaborn', 'PIL',                                  
                             'sklearn.model_selection', 'sklearn',                            
                             'sklearn.metrics']                                               
                             In order to get a complete experience of Viz,                    
                             please install the missing Kedro project                         
                             dependencies 

Should the updated message be -

[08/23/24 16:33:59] WARNING  In order to get a complete experience of Kedro-Viz,             data_loader.py:173             
                             please install the missing Kedro project dependencies below:                             
                             ['sklearn.base', 'matplotlib.pyplot',                            
                             'matplotlib', 'seaborn', 'PIL',                                  
                             'sklearn.model_selection', 'sklearn',                            
                             'sklearn.metrics']                  

Thank you

@stephkaiser
Copy link

I'd suggest:

[08/23/24 16:33:59] WARNING Kedro-Viz is running with limited functionality. For the best experience with full functionality, please install the missing Kedro project dependencies:
['sklearn.base', 'matplotlib.pyplot', 'matplotlib', 'seaborn', 'PIL', 'sklearn.model_selection', 'sklearn', 'sklearn.metrics']

let me know what you think @rashidakanchwala

@stephkaiser
Copy link

Designs for the warning banners can be found here - https://www.figma.com/design/3kSpvIO1veLKfy9qHxuXwF/Kedro-WIP?node-id=2550-103078

Let me know what you think about the information provided. The 'Learn more' button can link to documentation with more information about missing dependencies.

@rashidakanchwala
Copy link
Contributor

The design looks great to me. thanks @stephkaiser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design: UX Design: Visual Design Issue: Feature Request Javascript Pull requests that update Javascript code Python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants