-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI to Github actions migration for Kedro-Viz (test) #1846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jitendra, just had a look over the draft it looks great I've just left some minor comments. Happy to approve once its out of draft otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can combine build-frontend.yml
and javascript-lint-and-tests.yml
into one if build-frontend.yml
is just calling javascript-lint-and-tests.yml
. Otherwise everything looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @jitu5 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jitu5, this looks great!
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @jitu5 !! Excited to have gh-actions 🥇 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing LGTM!! feel free to merge once tests pass. thanks @jitu5
Description
Resolves #1785
Development notes
The migration from CircleCI to Github Actions will be have to done in parts. This PR addresses the following parts -
Reusable Workflows:
lint.yml
:all-checks.yml
&build-backend.yml
e2e-tests.yml
:all-checks.yml
&build-backend.yml
unit-tests.yml
:all-checks.yml
&build-backend.yml
javascript-lint-and-tests.yml
:all-checks.yml
package/**
paths.package/**
paths.all-checks.yml
:check-release.yml
(will be added in separate PR)unit-test.yml
,lint.yml
,e2e-tests.yml
andjavascript-lint-and-tests.yml
as separate jobs.Reusable Actions:
install_node_dependencies/action.yml
:e2e-tests.yml
,unit-tests.yml
,javascript-lint-and-tests.yml
andrelease.yml
(will be added in separate PR)install_python_dependencies/action.yml
:e2e-tests.yml
,unit-tests.yml
,javascript-lint-and-tests.yml
andlint.yml
setup_tests/action.yml
:e2e-tests.yml
andunit-tests.yml
.Workflows:
build-backend.yml
:package/**
&.github/**
pathspackage/**
&.github/**
pathsunit-test.yml
,lint.yml
ande2e-tests.yml
as separate jobs.Miro board link
The following will be added in separate PRs
Notes
cypress/fixtures/graphql/
totrufflehog-ignore.txt
because secret-scan was complaining some files under it.unit-tests.yml
&e2e-tests.yml
run on main and demo branches for Windows and all branch for ubuntu, This is what we had on CircleCI.Checklist
RELEASE.md
file