-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal redux state structure refactor #1983
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitu5
changed the title
Minimap props refactor:
Props refactor: Jul 17, 2024
display.miniMap
& visible.miniMap
display.miniMap
, visible.miniMap
& pipelineBtn
jitu5
force-pushed
the
feature/minimap-prop-refactor
branch
from
July 18, 2024 12:47
20382b4
to
faceed9
Compare
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
jitu5
changed the title
Props refactor:
Internal redux state structure refactor
Jul 18, 2024
display.miniMap
, visible.miniMap
& pipelineBtn
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
5 tasks
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
5 tasks
rashidakanchwala
approved these changes
Jul 19, 2024
ravi-kumar-pilla
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor rename comment, but overall looks fine. Thank you @jitu5
Signed-off-by: Jitendra Gundaniya <[email protected]>
Closing this PR as it already merged with #1992 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1969 (comment) point 2
To make React component options props consistent, Redux state structure is updated as below:
Current:
After this PR:
Development notes
visible
todisplay
which are buttons that can only be controlled by passing to react componentminiMapBtn
from redux stateminiMap
in bothdisplay
andvisible
display.miniMap
isfalse
both icon and miniMap will be hiddenvisible.miniMap
will be used internally when used without react component to show/hide miniMap when clicked by userexpandAllPipelines
out ofdisplay
and keep it same level asdisplay
pipelineBtn
renamed toexpandPipelinesBtn
###Note:
This PR is linked with #1982, #1969 and #1965
Checklist
RELEASE.md
file