Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v9.2.0 #2001

Merged
merged 12 commits into from
Jul 29, 2024
Merged

Release v9.2.0 #2001

merged 12 commits into from
Jul 29, 2024

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Jul 25, 2024

Description

Release 9.2.0

Major features and improvements

Bug fixes and other changes

Community contributions

Many thanks to the following Kedroids for contributing PR to this release:

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB SajidAlamQB self-assigned this Jul 25, 2024
@SajidAlamQB SajidAlamQB marked this pull request as ready for review July 25, 2024 13:14
@ravi-kumar-pilla
Copy link
Contributor

Hi @SajidAlamQB , Thank you for the release PR.

Some PRs worth mentioning in the Release -

  1. Set isPrettyName to False by Default Set isPrettyName to False by Default #1958. - (User facing change, might be worth mentioning)
  2. Added "-p" cli option to match kedro pipeline options added "-p" cli option to match kedro pipeline options #1961. - (Worth mentioning as community contribution)
  3. Refactor: Replace data-heap-event with standardized data-test for Cypress and Telemetry Refactor: Replace data-heap-event with standardized data-test for Cypress and Telemetry #1995. - (For our tracking)

I hope there will be some update to the reminder content. Thank you

Signed-off-by: Sajid Alam <[email protected]>
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship-it

Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work team! 🎉

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Jul 26, 2024

Hi Team,

When I refresh viz after selecting a different pipeline, it resets back to default. I would like if someone can test this behavior (pid resetting to default on refresh) and confirm. I think this is a bug (v9.0.0 works fine. The issue started in v9.1.0). Thank you

cc: @jitu5

pipeline_resetting_to_default

@jitu5
Copy link
Contributor

jitu5 commented Jul 26, 2024

Hi Team,

When I refresh viz after selecting a different pipeline, it resets back to default. I would like if someone can test this behavior (pid resetting to default on refresh) and confirm. I think this is a bug (v9.0.0 works fine. The issue started in v9.1.0). Thank you

cc: @jitu5

@ravi-kumar-pilla its already on demo site, and Huong already created bug ticket on this #1997

Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @SajidAlamQB

@Huongg
Copy link
Contributor

Huongg commented Jul 26, 2024

i tested the branch locally and all the UI changes are working as expect. Great job team, looking forward to releasing to our users ❤️

Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-26 at 20 53 00
  • If we can do so, could we add some formatting to the text to make certain key words bold
    'enable' , 'disable', .viz etc.
  • Also, could we add link to the documentation to show how they can disable in CLI and in UI
  • Also link to npm readme file for React Component
  • The session store (a SQLite database) and the stats file are now conditionally
  • to store session data and stat files?

@SajidAlamQB
Copy link
Contributor Author

  • The session store (a SQLite database) and the stats file are now conditionally
  • to store session data and stat files?

What do you mean by these two points?

Signed-off-by: Sajid Alam <[email protected]>
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @SajidAlamQB

@SajidAlamQB SajidAlamQB merged commit d58ccce into main Jul 29, 2024
25 checks passed
@SajidAlamQB SajidAlamQB deleted the release/9.2.0 branch July 29, 2024 14:52
@SajidAlamQB SajidAlamQB mentioned this pull request Jul 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants