Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Documentation for Dataset Previews #2074

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Sep 3, 2024

Description

Related to: #1884 and #1847

Update the documentation for dataset preview functionality. It clarifies the expected return type and data structure for TablePreview.

Development notes

Expanded the documentation to provide clear guidance on the required data format for TablePreview.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB SajidAlamQB self-assigned this Sep 3, 2024
@@ -11,7 +11,14 @@ PlotlyPreview = NewType("PlotlyPreview", dict)
JSONPreview = NewType("JSONPreview", dict)
```

Arbitrary arguments can be included in the `preview()` function, which can be later specified in the `catalog.yml` file.
## TablePreview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could do it for every Preview we have

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code snippet and prose look good now 👍🏼

@SajidAlamQB SajidAlamQB marked this pull request as ready for review September 6, 2024 11:33
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the screenshots from the examples section now within each of the dataset section and remove that example section altogether. thanks :)

Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB SajidAlamQB merged commit d3fc51f into main Sep 10, 2024
10 checks passed
@SajidAlamQB SajidAlamQB deleted the docs/datasets-preview-docs-update branch September 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants