-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Documentation for Dataset Previews #2074
Conversation
Signed-off-by: Sajid Alam <[email protected]>
@@ -11,7 +11,14 @@ PlotlyPreview = NewType("PlotlyPreview", dict) | |||
JSONPreview = NewType("JSONPreview", dict) | |||
``` | |||
|
|||
Arbitrary arguments can be included in the `preview()` function, which can be later specified in the `catalog.yml` file. | |||
## TablePreview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could do it for every Preview we have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code snippet and prose look good now 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add the screenshots from the examples section now within each of the dataset section and remove that example section altogether. thanks :)
Signed-off-by: Sajid Alam <[email protected]>
Description
Related to: #1884 and #1847
Update the documentation for dataset preview functionality. It clarifies the expected return type and data structure for
TablePreview
.Development notes
Expanded the documentation to provide clear guidance on the required data format for
TablePreview
.Checklist
RELEASE.md
file