Flowchart Orientation #2251
Open
Flowchart Orientation #2251
+653
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
Signed-off-by: rashidakanchwala <[email protected]>
astrojuanlu
reviewed
Feb 6, 2025
SajidAlamQB
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Awesome work @rashidakanchwala, tested it manually and looks great!
| ariaLabel="Change flowchart orientation" | ||
| className={'pipeline-menu-button--orientation'} | ||
| dataTest={'sidebar-flowchart-orientation-btn'} | ||
| icon={orientation === 'vertical' ? TopBottomIcon : LeftRightIcon} |
There was a problem hiding this comment.
should this be opposite ? Like when vertical we show LeftRightIcon to change, similar to expand/collapse pipelines ?
| ? (node.width + 20) / -2 | ||
| : -(node.width / 2) + 10 | ||
| ) | ||
| .attr('y', (node) => (orientation === 'vertical' ? -6 : -node.height + 12)); |
There was a problem hiding this comment.
Will it be possible to add some comments on these calculations for future ref ? Thank you
| const { chartSize, layers, orientation } = this.props; | ||
|
|
||
| const layerNamePosition = | ||
| orientation === 'vertical' ? chartSize.sidebarWidth || 0 : 100 || 0; |
There was a problem hiding this comment.
Will it be possible to add some comments on these calculations for future ref ? Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2159
Development notes
For first PR review, pls QA it and look through the code. I will add dev notes when i am back from PTO
QA notes
Checklist
RELEASE.mdfile