Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready] Update docs in the notebooks section #3098

Closed
wants to merge 13 commits into from

Conversation

stichbury
Copy link
Contributor

@stichbury stichbury commented Sep 29, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Ongoing work to improve section of docs. Addresses #2845

Development notes

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@stichbury stichbury changed the title [Draft, no reviews] Update docs in the notebooks section [Ready] Update docs in the notebooks section Oct 4, 2023
@stichbury
Copy link
Contributor Author

@astrojuanlu Ready for an initial review. More comments from me over on #2855

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this when https://beta.readthedocs.org/projects/kedro/builds/22122501/ passes, added nbsphinx to dependencies

In the meantime, what notebook version do you have? I think it would be a good moment to take those screenshots with >=7.0, I can help with this

@stichbury
Copy link
Contributor Author

Closing this PR and creating two new ones as it's getting too large.

@stichbury stichbury closed this Oct 5, 2023
@merelcht merelcht deleted the revise-notebook-section branch November 21, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants