Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ephemeral attribute to main branch #3566

Merged
merged 12 commits into from
Jan 29, 2024

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Jan 29, 2024

Description

Adds the _EPHEMERAL attribute to the AbstractDataset class. This attribute will serve to indicate if a Dataset object is persistent or not. It is set to be False by default, and should be changed to True in case a Dataset is not meant to be persistent, as seen, for example, in MemoryDataset.

Development notes

Comments and discussion can be seen on #3520

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@lrcouto lrcouto marked this pull request as ready for review January 29, 2024 15:25
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lrcouto!

@ankatiyar ankatiyar requested a review from noklam January 29, 2024 16:09
@lrcouto lrcouto merged commit 4f94b17 into main Jan 29, 2024
34 checks passed
@lrcouto lrcouto deleted the add-ephemeral-attribute-to-main-branch branch January 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants