Performance tests for DataCatalog
#4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noklam
reviewed
Oct 15, 2024
ElenaKhaustova
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Thank you, @ankatiyar!
I added nit comments and they're both related to the ocl PR.
benchmarks/benchmark_ocl.py
Outdated
| self.conf_source = Path(self.temp_dir.name) | ||
|
|
||
| # Create sample config files in the temp directory | ||
| _create_config_file(self.conf_source, "base", "catalog.yml", base_catalog) |
There was a problem hiding this comment.
Can we maybe replace this with a loop?
There was a problem hiding this comment.
yea let me see if i can simplify it
|
Could we wait until we merge #4218 for |
Fixed an erroneous link to the Get started with Kedro - Create your first data pipeline with Kedro video. It was accidentally linked to the previous video. Signed-off-by: Greg Vaslowski <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
* Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 Bumps [kedro-sphinx-theme](https://github.com/kedro-org/kedro-sphinx-theme) from 2024.4.0 to 2024.10.0. - [Release notes](https://github.com/kedro-org/kedro-sphinx-theme/releases) - [Commits](kedro-org/kedro-sphinx-theme@v2024.4.0...v2024.10.0) --- updated-dependencies: - dependency-name: kedro-sphinx-theme dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * updated to 2024.10.2 * trigger_run * trigger_run --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: L. R. Couto <[email protected]> Co-authored-by: rashidakanchwala <[email protected]> Co-authored-by: Ankita Katiyar <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
…ages (#4145) * Load manually created sitemap Signed-off-by: Dmitry Sorokin <[email protected]> * Add projects remove lastmod for latest Signed-off-by: Dmitry Sorokin <[email protected]> * Add latest for projects Signed-off-by: Dmitry Sorokin <[email protected]> --------- Signed-off-by: Dmitry Sorokin <[email protected]> Co-authored-by: Dmitry Sorokin <[email protected]> Co-authored-by: ElenaKhaustova <[email protected]> Co-authored-by: L. R. Couto <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
* Bump up version to 0.19.9 Signed-off-by: Laura Couto <[email protected]> * Add placeholders to release.md Signed-off-by: Laura Couto <[email protected]> * Update citation.cff release date Signed-off-by: Laura Couto <[email protected]> --------- Signed-off-by: Laura Couto <[email protected]> Signed-off-by: L. R. Couto <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
* Update project structure docs --------- Signed-off-by: Dmitry Sorokin <[email protected]> Signed-off-by: Dmitry Sorokin <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
* Update CLI autocompletion docs with new Click syntax Updated the autocompletion setup instructions for Bash, Zsh, and Fish shells to reflect the latest Click 8.1 syntax. Changed Fish shell completion script path to ~/.config/fish/completions/kedro.fish for correct placement. Signed-off-by: hyew0nChoi <[email protected]> Signed-off-by: Ankita Katiyar <[email protected]>
Bumps [import-linter](https://github.com/seddonym/import-linter) from 2.0 to 2.1. - [Changelog](https://github.com/seddonym/import-linter/blob/master/CHANGELOG.rst) - [Commits](seddonym/import-linter@v2.0...v2.1) --- updated-dependencies: - dependency-name: import-linter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ankita Katiyar <[email protected]>
* first pass doesn't work yet Signed-off-by: Ankita Katiyar <[email protected]> * Update ocl tests Signed-off-by: Ankita Katiyar <[email protected]> * revert some changes Signed-off-by: Ankita Katiyar <[email protected]> * Update to use larger config Signed-off-by: Ankita Katiyar <[email protected]> * Update functions and docstrings Signed-off-by: Ankita Katiyar <[email protected]> * lint Signed-off-by: Ankita Katiyar <[email protected]> --------- Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
This reverts commit 0dbe3c7. Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
ankatiyar
force-pushed
the
performance-datacatalog
branch
from
029c993
to
821401d
Compare
Signed-off-by: Ankita Katiyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially resolve #4125
Development notes
Added performance tests for
DataCatalogI'm wondering if it's worth adding them for
KedroDataCatalogas well, since the interface is still in active development?Ignore
benchmark_ocl.pysince that is under review in #4225To run locally:
asv runorasv run --quickDeveloper Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile