Add tests for resume scenario suggestion to parallel runner #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <[email protected]>
* Try fix flaky thread runner test Signed-off-by: Merel Theisen <[email protected]> * Fix dict into list for iteration Signed-off-by: Merel Theisen <[email protected]> --------- Signed-off-by: Merel Theisen <[email protected]>
tests/runner/test_thread_runner.py
Outdated
| @@ -311,7 +311,7 @@ def test_stricter_suggest_resume_scenario( | |||
| """ | |||
| test_pipeline = two_branches_crossed_pipeline_variable_inputs | |||
|
|
|||
| nodes = {n.name: n for n in test_pipeline.nodes} | |||
| nodes = {n.name: n for n in list(test_pipeline.nodes)} | |||
There was a problem hiding this comment.
Shouldn't test_pipeline.nodes already return a list?
There was a problem hiding this comment.
I was trying to fix the issue that this test is flaky because of an iterable changing size. test_pipeline is changed below so I thought this might solve it. But I'll move this to my other PR for fixing the tests.
ElenaKhaustova
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thank you, @merelcht!
Implementation looks good to me, left one minor question.
Signed-off-by: Merel Theisen <[email protected]>
ankatiyar
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1830
Development notes
The refactoring in #4353 already added the resume suggestion to ParallelRunner. This PR adds tests to check the suggestions work as expected.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile