-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kedro-viz backend server, fetch data directly instead #70
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9024210
Kedro viz server removed
jitu5 b0e10a4
get_json_data renamed to get_kedro_project_json_data
jitu5 a295fa6
fix reload lsp without disconnect webview
noklam a411bc4
Merge pull request #74 from kedro-org/noklam/viz-webview-reload-server
jitu5 a17a1fa
Merge branch 'main' into viz/viz-py-package
noklam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -83,6 +83,8 @@ | |||||
) | ||||||
from pygls.server import LanguageServer | ||||||
|
||||||
from kedro_viz.server import load_and_populate_data | ||||||
from kedro_viz.api.rest.responses import get_kedro_project_json_data | ||||||
|
||||||
class KedroLanguageServer(LanguageServer): | ||||||
"""Store Kedro-specific information in the language server.""" | ||||||
|
@@ -553,6 +555,21 @@ def definition_from_flowchart(ls, word): | |||||
result = definition(LSP_SERVER, params=None, word=word) | ||||||
return result | ||||||
|
||||||
@LSP_SERVER.command("kedro.getProjectData") | ||||||
def get_porject_data_from_viz(lsClient): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"""Get project data from kedro viz | ||||||
""" | ||||||
data = None | ||||||
try: | ||||||
load_and_populate_data(Path.cwd()) | ||||||
data = get_kedro_project_json_data() | ||||||
return data | ||||||
except Exception as e: | ||||||
print(f"An error occurred: {e}") | ||||||
finally: | ||||||
print("Execution completed.") | ||||||
return data | ||||||
|
||||||
### End of kedro-lsp | ||||||
|
||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this force extension users to upgrade
kedro-viz
? Or does this only affect the extension environment?