Skip to content

Commit

Permalink
Increase maintainer's redemption request amount limit to 15 BTC
Browse files Browse the repository at this point in the history
The wallet maintainer bot contains a safety net which forces it to not
include requests exceeding 10 BTC in the automatically submitted redemption
proposals. Such requests are processed manually after confirming they are not
part of a broader malicious action. The redemption mechanism proved
to perform well since its release so, we can increase the limit to 15 BTC
and reduce the need of manual intervention.
  • Loading branch information
lukasz-zimnoch committed Sep 12, 2023
1 parent 9c62b5b commit 13f8ff1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ configMapGenerator:
literals:
- network=mainnet
- electrum-api-url=ws://electrumx.bitcoin:8080
- redemption-request-amount-limit=1500000000 # 15 BTC in satoshi
files:
- .secret/keep-maintainer-keyfile

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ configMapGenerator:
literals:
- network=testnet
- electrum-api-url=ws://electrumx.bitcoin-testnet:8080
- redemption-request-amount-limit=0 # Use the default value
files:
- .secret/keep-maintainer-keyfile

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ spec:
configMapKeyRef:
name: keep-maintainer-config
key: electrum-api-url
- name: REDEMPTION_REQUEST_AMOUNT_LIMIT
valueFrom:
configMapKeyRef:
name: keep-maintainer-config
key: redemption-request-amount-limit
command:
- keep-client
- maintainer
Expand All @@ -57,6 +62,8 @@ spec:
- /mnt/keep-maintainer/keyfile/keep-maintainer-keyfile
- --bitcoin.electrum.url
- $(ELECTRUM_API_URL)
- --walletCoordination.redemptionRequestAmountLimit
- $(REDEMPTION_REQUEST_AMOUNT_LIMIT)
volumeMounts:
- name: eth-account-keyfile
mountPath: /mnt/keep-maintainer/keyfile
Expand Down

0 comments on commit 13f8ff1

Please sign in to comment.