Skip to content

Commit

Permalink
Set Node.js version to 18.15.0 (#3633)
Browse files Browse the repository at this point in the history
We want to prevent the problem with generation of artifacts during
execution of the `hardhat compile` command (part of `yarn deploy`). We
saw in other project that sometimes command was not not generating
expected artifacts. The problem is caused by the process silently
quitting, which is related to the used version of Node (as described in
NomicFoundation/hardhat#3877). We've confirmed
the problem is reproducible on `v18.16.0`, now we're downgrading to
`v18.15.0` to fix the issue.

Refs:
#3595
threshold-network/solidity-contracts#145
  • Loading branch information
dimpar authored Jun 13, 2023
2 parents c599f2f + f2d2f58 commit fabd15b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/npm-ecdsa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 may cause issues with the
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877.
node-version: "18.15.0"
registry-url: "https://registry.npmjs.org"
cache: "yarn"
cache-dependency-path: solidity/ecdsa/yarn.lock
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/npm-random-beacon.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: "18.x"
# Using fixed version, because 18.16 may cause issues with the
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877.
node-version: "18.15.0"
registry-url: "https://registry.npmjs.org"
cache: "yarn"
cache-dependency-path: solidity/random-beacon/yarn.lock
Expand Down

0 comments on commit fabd15b

Please sign in to comment.