[Do not merge] dApp-friendly contract deployment #3118
Conversation
Change the `authorizationDecreaseDelay` and `authorizationDecreaseChangePeriod` to `180` seconds in `RandomBeacon` and `WalletRegistry`. It means that we can test the authroziation decrease flow faster in the T dapp on testnet.
|
Could you change this PR to draft and add a visible info in the description that those changes are not supposed to get merged to |
CODEOWNERS
Outdated
| /solidity/random-beacon/contracts/RandomBeacon.sol @pdyraga @nkuba @lukasz-zimnoch | ||
| /solidity/ecdsa/contracts/WalletRegistry.sol @pdyraga @nkuba @lukasz-zimnoch |
There was a problem hiding this comment.
Let's extract CODEOWNERS change to a separate PR and merge it to main.
The CODEOWNERS should cover two contracts listed here as well as all files in:
solidity/ecdsa/contracts/librariessolidity/ecdsa/contracts/apisolidity/random-beacon/contracts/libraries/solidity/random-beacon/contracts/api
Let's add there all developers who worked on the Solidity code of the mentioned smart contracts: @pdyraga @nkuba @lukasz-zimnoch @dimpar @tomaszslabon.
This will not only protect dApp-dev-only changes from being merged but will also protect from any accidental changes to an already audited code.
pdyraga
changed the title
r-czajkowski
force-pushed
the
dapp-development
branch
from
1eaebce
to
6348927
Compare
We need to create the mocked wallet in this contract because the tbtc-v2.ts lib looks up wallet by id to get the active wallet public key. Please see https://github.com/keep-network/tbtc-v2/blob/main/typescript/src/ethereum.ts#L392-L395. The `Bridge` contract from the `tbtc-v2` stores the hash of the wllet's public key not public key.
|
@r-czajkowski, when I tested the deployment of This happens both on |
| ) external { | ||
| wallets.registry[ecdsaWalletID].publicKeyX = publicKeyX; | ||
| wallets.registry[ecdsaWalletID].publicKeyY = publicKeyY; | ||
| emit WalletCreated(ecdsaWalletID, 0x0); |
There was a problem hiding this comment.
Maybe use some dummy value instead of 0x0 which seems a default empty value?
After merging the `main` branch we hit the `WalletRegisrty` contract size limit. So here we get rid of the `WalletCreated` event to reduce the contract size.
Set `dapp-development-goerli` tag for `@keep-network/random-beacon` and `@threshold-network/solidity-contracts`. We need dapp-friendly contracts here.
We are publishing packages with code from `dapp-development` branch under versions that use `-dapp-dev-goerli.X` suffix. Our `package.json` on this branch should reflect that. If we do not set it up, the CI job used to pubblish the package will not be able to correctly bump up the version of the package.
Set `dapp-development-goerli` tag for `@threshold-network/solidity-contracts`. We need dapp-friendly contracts here.
michalinacienciala
force-pushed
the
dapp-development
branch
from
8b6a807
to
c83d6f1
Compare
We need the latest version of the `@threshold-network/solidity-contrcts` with the `dapp-development-goerli` tag.
We need the latest version of the `@threshold-network/solidity-contracts` and `keep-network/random-beacon` with the `dapp-development-goerli` tag.
We changed the version range for `@tenderly/hardhat-tenderly` in #3454 (ecdsa package) and CI build fails on tenderly verification. The tenderly verification passes in random-beacon package because we use a fixed `1.0.12` version. Since this is a `dapp-development` branch, we do not actually need the tenderly verification at least for now so here we remove the `tenderly` tag for `goerli` network to skip the tenderly verification.
We're switching deployment to the Sepolia testnet due to planned deprecation of the Goerli testnet. In a previous commit we've updated the `dapp-development` branch with the recent changes from `main` (among them were the changes adding Sepolia to the list of supported networks). Now we're updating the `dapp-development` branch to create `dapp-dev-sepolia` packages.
We're switching deployment to the Sepolia testnet due to planned deprecation of the Goerli testnet. In a previous commit we've updated the `dapp-development` branch with the recent changes from `main` (among them were the changes adding Sepolia to the list of supported networks). Now we're updating the `dapp-development` branch to create `dapp-dev-sepolia` packages.
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/6786867212 check. |
|
Solidity API documentation preview available in the artifacts of the https://github.com/keep-network/keep-core/actions/runs/6786867235 check. |
Ref: threshold-network/token-dashboard#136
We need a dApp-friendly version of deployment allowing dashboard developers to build UI components without having to run geth/ganache/hardhat locally and deploying contracts locally.
This PR aims at presenting changes to smart contracts deployed to Sepolia that are used by the dApp development team for day-to-day work. Please do not merge this PR to
mainbranch. Smart contract with the changes presented here are pushed to NPM registry with a tagdapp-development-sepolia.Main changes:
authorizationDecreaseDelayandauthorizationDecreaseChangePeriodto180 secondsinstead of45 days, so we can test the authorization decrease flow faster in the T dapp on testnet.