Fix the wallets limit filter in the wallet maintainer redemptions code #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic is wrong as, if the `WalletsLimit` filter is on, always the same wallets will be taken into account so redemption requests targeting newer wallets can be missed by the wallet maintainer. We are fixing that by applying the `WalletsLimit` filter at a later stage.
pdyraga
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3682
As described in #3682, the current logic is wrong. If the
WalletsLimitfilter is on, always the same oldest wallets will be taken into account so redemption requests targeting newer wallets can be missed by the wallet maintainer. We are fixing that by applying theWalletsLimitfilter at a later stage.