Remove deprecation notice for --mainnet flag #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We planned to remove the `--mainnet` flag, as it seemed unnecessary, as the client running without any network flag runs for mainnet by default. But from infrastructure adminstrator perspective the flag may be actually usefull when running the application on multiple environments. It's much easier to maintain a common template where the administrator will have to change value of the flag rather than set the flag for some environments and remove it for mainnet.
dimpar
reviewed
Sep 12, 2023
| cmd.PersistentFlags().Bool( | ||
| network.Mainnet.String(), | ||
| false, | ||
| "Mainnet network (DEPRECATED)", | ||
| "Mainnet network", |
There was a problem hiding this comment.
On line 99 we have a comment about removing the mainnet flag. Can you pls also remove it?
|
Left just one minor comment. Looks good to me. |
dimpar
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We planned to remove the
--mainnetflag, as it seemed unnecessary, as the client running without any network flag runs for mainnet by default. But from an infrastructure administrator perspective, the flag may be actually useful when running the application on multiple environments. It's much easier to maintain a common template where the administrator will have to change the value of the flag rather than set the flag for some environments and remove it for mainnet.When running the application for mainnet an administrator will have two possibilities:
--mainnetflag,When running the application for testnet an administrator will have to add
--testnetflag.