Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking a different wallet address which hasn't recorded any tx recently #3704

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

dimpar
Copy link
Contributor

@dimpar dimpar commented Sep 1, 2023

The recent tx that happened for this address was 3 weeks ago and no movement was recorded since then. A new tx recently appeared on the existing address which means it is still in use, hence the change.

The recent tx that happened for this address was 3 weeks ago and no
movement was recorded since then. A new tx recently appeared on the
existing address which means it is still in use, hence the change.
@tomaszslabon tomaszslabon merged commit eec2e6a into main Sep 6, 2023
29 checks passed
@tomaszslabon tomaszslabon deleted the integration-test-fixes branch September 6, 2023 13:37
@dimpar dimpar added this to the v2.0.0-m5 milestone Sep 7, 2023
lukasz-zimnoch added a commit that referenced this pull request Sep 14, 2023
Refs #3699

Depends on #3704

It happens that the keep-core client panics when interacting with the
`go-electrum` library. We noticed a "concurrent write to websocket
connection" error was thrown when calling `GetLatestBlockHeight()`
function. The stack trace leads to gorilla/websocket/WriteMessage which
is called from the `go-electrum` library. The latest block height call
was already wrapped with a read mutex, but we should also wrap it with
the write mutex to prevent such concurrent errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants