Increasing signing attempts to perform all signing computations #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the current number attempts is not enough and we need to bump it up so the integration tests computation have enough time to perform signing. The reason why they started failing is because local chain has block times much shorter than the real ones. This will give much shorter timeouts to perform all the signning computation.
tomaszslabon
approved these changes
Sep 12, 2023
tomaszslabon
deleted the
increase-attempts-in-signing-integration-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3665
It turns out that the current number of attempts is not enough and we need to bump it up so the integration tests computation has enough time to perform signing. The reason why they started failing is because the local chain has block times much shorter than the real ones. This will give much shorter timeouts to perform all the signing computations.
Credits: The fix was suggested by @lukasz-zimnoch