Archive key material on wallet closure #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
archive-key-material
branch
2 times, most recently
from
849019d
to
855631d
Compare
tomaszslabon
force-pushed
the
archive-key-material
branch
from
855631d
to
accb4b1
Compare
tomaszslabon
force-pushed
the
archive-key-material
branch
from
a9ce97a
to
655f899
Compare
tomaszslabon
force-pushed
the
archive-key-material
branch
from
655f899
to
cddb143
Compare
tomaszslabon
force-pushed
the
archive-key-material
branch
from
b89bc97
to
f0eca28
Compare
tomaszslabon
force-pushed
the
archive-key-material
branch
from
95c56bb
to
ae34178
Compare
lukasz-zimnoch
previously approved these changes
Jun 11, 2024
lukasz-zimnoch
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Refs: #3797.
This PR handles archiving key material on wallet closures.
Archiving the wallet data happens in two situations:
WalletClosedevent is receivedArchiving wallet's key material causes the wallet data to be moved to the
archivedirectory and the wallet is removedform the registry's cache..
Such wallets will no longer participate in the RFC-12 coordination.